build: migrate avatar, accordion and label to secondary entrypoints #514
Conversation
libs/ui/slider/brain/package.json
Outdated
| "@angular/common": ">=18.0.0", | ||
| "@angular/core": ">=18.0.0", | ||
| "@angular/cdk": ">=18.0.0", | ||
| "@angular/forms": ">=18.0.0", | ||
| "rxjs": ">=6.6.0" | ||
| "rxjs": ">=6.6.0", | ||
| "@spartan-ng/brain": "0.0.1-alpha.357" |
There was a problem hiding this comment.
is there a way to order these automatically as part of the migration?
There was a problem hiding this comment.
I think this was added by ESLint Nx dependency checks rule rather than the migration itself in this case.
That being said I could add this prettier plugin https://github.com/matzkoh/prettier-plugin-packagejson to always ensure our deps are sorted correctly if you'd like?
There was a problem hiding this comment.
Up to you. I mean it's a nice to have, but doesn't really matter too much. I'll trust your judgement!
There was a problem hiding this comment.
Pushed a commit there now including it, we can give it a go, if its not what we want we can always remove it I suppose.
ashley-hunter
force-pushed
the
additional-secondary-entrypoints
branch
from
00c6358 to
1bd4484
Compare
|
One comment about prettier tailwind plugin! |
PR Checklist
Please check if your PR fulfills the following requirements:
guidelines: https://github.com/goetzrobin/spartan/blob/main/CONTRIBUTING.md#-commit-message-guidelines
PR Type
What kind of change does this PR introduce?
Which package are you modifying?
What is the current behavior?
N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
A breaking change, but with a generator/schematic to auto migrate it