fix(dropdown-menu,context-menu,menubar): set our menu side to default… #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s if no prev position we are using some ugly workaround to store the last position, of the menu we opened and then set the side based on that. sometimes there is no last position available so we should just set to defaults and return instead of throwing an error trying to access an undefined object closes #553
ashley-hunter
approved these changes
Feb 6, 2025
elite-benni
approved these changes
Feb 8, 2025
elite-benni
pushed a commit
to elite-benni/spartan
that referenced
this pull request
Feb 12, 2025
…s if no prev position (spartan-ng#581) we are using some ugly workaround to store the last position, of the menu we opened and then set the side based on that. sometimes there is no last position available so we should just set to defaults and return instead of throwing an error trying to access an undefined object closes spartan-ng#553
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s if no prev position
we are using some ugly workaround to store the last position, of the menu we opened and then set the side based on that. sometimes there is no last position available so we should just set to defaults and return instead of throwing an error trying to access an undefined object
closes #553
PR Checklist
Please check if your PR fulfills the following requirements:
guidelines: https://github.com/goetzrobin/spartan/blob/main/CONTRIBUTING.md#-commit-message-guidelines
PR Type
What kind of change does this PR introduce?
Which package are you modifying?
What is the current behavior?
Closes #553
What is the new behavior?
Does this PR introduce a breaking change?
Other information