Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): default hlm-select-option icon size #585

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

0xfraso
Copy link
Contributor

@0xfraso 0xfraso commented Feb 6, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • accordion
  • alert
  • alert-dialog
  • aspect-ratio
  • avatar
  • badge
  • button
  • calendar
  • card
  • checkbox
  • collapsible
  • combobox
  • command
  • context-menu
  • data-table
  • date-picker
  • dialog
  • dropdown-menu
  • hover-card
  • icon
  • input
  • label
  • menubar
  • navigation-menu
  • pagination
  • popover
  • progress
  • radio-group
  • scroll-area
  • select
  • separator
  • sheet
  • skeleton
  • slider
  • sonner
  • spinner
  • switch
  • table
  • tabs
  • textarea
  • toast
  • toggle
  • tooltip
  • typography

What is the current behavior?

Closes #

What is the new behavior?

Closes #584

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@0xfraso 0xfraso force-pushed the fix/hlm-select-option-icon branch from 03891e6 to f57bacb Compare February 6, 2025 13:56
Copy link
Collaborator

@ashley-hunter ashley-hunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Nice fix!

@goetzrobin goetzrobin merged commit e16c3c0 into spartan-ng:main Feb 10, 2025
6 checks passed
elite-benni pushed a commit to elite-benni/spartan that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check Icon inside HlmOption is cut off
4 participants