-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add DASK_GAUSSIAN scaling and fix ITK_GAUSSIAN #40
Conversation
Changes: - Adds `DASK_GAUSSIAN` scaling option which combines dask_image Gaussian blurring with ITK's ResampleImageFilter for downsampling - Resolves issue in ITK_GAUSSIAN where kernel radius was improperly set from local block metadata, resulting severely different images from DASK_GAUSSIAN blurring results - Adds tests and update baseline images
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tbirdso awesome!!
Can we use something from dask-image
for the resampling so we do not have the itk
dependency for this method? E.g. affine_transform
, map_coordinates
The `DASK_GAUSSIAN` method previously relied on ITK for calculating output metadata at each scale and resampling after dask_image blurring. This commit updates the `DASK_GAUSSIAN` procedure to manually compute output metadata without ITK and to use the dask_image `affine_transform` method for downsampling.
@thewtex Please see updated changes substituting Does |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tbirdso beautiful!! ✨
That's really cool to see. Thanks for sharing and working on this Matt and Tom! 😄 |
Changes:
DASK_GAUSSIAN
scaling option which combines dask_image Gaussianblurring with ITK's ResampleImageFilter for downsampling
resulting in severely different images from DASK_GAUSSIAN blurring results
Note that Gaussian kernels with same sigma value are still generated slightly differently between ITK and dask_image, so baseline image magnitudes differ by a small amount.