Support for cell attachments #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgeier
force-pushed
the
cell-attachments
branch
from
7fe0008 to
7f6cc53
Compare
mgeier
force-pushed
the
cell-attachments
branch
from
69057ef to
2c25c75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, only the documentation is there, the implementation is missing.
Currently, we only have access to the cell metadata from within the Jinja template, and I don't know how to save the attachment data there.
I guess it has to be saved to disk for Sphinx to be able to use it.
I'm open for suggestions!
Once #36 is implemented, this should be easier.
See also #29.