This repository has been archived by the owner on Jan 18, 2022. It is now read-only.
Update GameObjectCreatorFromMetadata.cs #681
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it's nice to have a chance to modify prefab before Instantiate. Since you are not accept PR, you can take this as a feedback.
improbable-prow-robot
added
the
size/XS
jamiebrynes7
added
S: being-considered
|
Thank you for your contribution! We like the idea and have discussed this internally. Instead of passing in an extra parameter, we are considering making the methods in the What do you think about this? |
jessicafalk
added
S: needs-info
|
That will do too. |
|
I created #687 to track progress of this feature. |
jessicafalk
added
S: accepted
jessicafalk
pushed a commit
that referenced
this pull request
Nov 15, 2019
* Error if blueprint RPCs have by ref arguments * Add known issue * Update SpatialGDK/Documentation/known-issues.md Co-Authored-By: improbable-valentyn <32096431+improbable-valentyn@users.noreply.github.com>
jessicafalk
pushed a commit
that referenced
this pull request
Nov 15, 2019
* Error if blueprint RPCs have by ref arguments * Add known issue * Update SpatialGDK/Documentation/known-issues.md Co-Authored-By: improbable-valentyn <32096431+improbable-valentyn@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it's nice to have a chance to modify prefab before Instantiate.
Since you are not accept public PR, you can take this as a feedback and close it.