Add DESCRIPTION to ICS output #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alies-dev
approved these changes
Dec 11, 2022
There was a problem hiding this comment.
Looks good to me!
If X-ALT-DESC;FMTTYPE has a limited support, we should remove it. The goal of this library to support only core functionality and be extendable for custom Generators. So, if someone needs X-ALT-DESC;FMTTYPE=text/html or other custom fields, you can always create your own generator and use \Spatie\CalendarLinks\Link::formatWith() method.
In case of ICS, there is another way of customisation: use $options parameter within \Spatie\CalendarLinks\Link::ics().
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context and Purposes
Closes #157.
Notes
All the ICS tests are failing on
master. Since I added a new field to the output I replaced the snapshots and now those tests are all passing. I'm unsure if this has inadvertently overwritten some sort of regression -- the only difference in the snapshots appears to be the changes I made for this branch.