Merge branch 'master' of github.com:spatie/dns

CHANGELOG.md

@@ -2,6 +2,6 @@
 
 All notable changes to `dns` will be documented in this file
 
-## 1.0.0 - 201X-XX-XX
+## 1.0.0 - 2017-11-03
 
 - initial release

src/Dns.php

@@ -22,7 +22,7 @@ class Dns
 
     public function __construct(string $domain)
     {
-        if ($domain === '') {
+        if (empty($domain)) {
             throw InvalidArgument::domainIsMissing();
         }
 
@@ -42,9 +42,7 @@ public function getRecords(...$types): string
             ? $types
             : $this->recordTypes;
 
-        $dnsRecords = array_map(function ($type) {
-            return $this->getRecordsOfType($type);
-        }, $types);
+        $dnsRecords = array_map([$this, 'getRecordsOfType'], $types);
 
         return implode('', array_filter($dnsRecords));
     }
@@ -55,9 +53,7 @@ protected function determineTypes(array $types): array
             ? $types[0]
             : $types;
 
-        $types = array_map(function (string $type) {
-            return strtoupper($type);
-        }, $types);
+        $types = array_map('strtoupper', $types);
 
         foreach ($types as $type) {
             if (! in_array($type, $this->recordTypes)) {
@@ -72,7 +68,7 @@ protected function sanitizeDomainName(string $domain): string
     {
         $domain = str_replace(['http://', 'https://'], '', $domain);
 
-        $domain = $this->stringBefore($domain, '/');
+        $domain = strtok($domain, '/');
 
         return strtolower($domain);
     }
@@ -91,15 +87,4 @@ protected function getRecordsOfType(string $type): string
 
         return $process->getOutput();
     }
-
-    protected function stringBefore(string $subject, string $search): string
-    {
-        $position = strpos($subject, $search);
-
-        if ($position === false) {
-            return $subject;
-        }
-
-        return substr($subject, 0, $position);
-    }
 }