fixes socket_select interrupted exception #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #31, when using pcntl_signal, socket_select may get interrupted which will cause an ErrorException being thrown.
The message is: socket_select(): unable to select [4]: Interrupted system call.
With this fix, the ErrorException is catched, and when the error number is 4 (the interrupted system call), the while loop is continued and the socket_select is run again.
I have no tests, as this is very difficult to test as this appears to be occurring randomly. I have tested it manually however and the error seems to be gone. Also the existing unit tests still succeeds.