Fixed #36 (Terminating a process after its execution does not work correctly) #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could your experiment with ways to fix the graceful termination on PHP 8.2? |
zKoz210
changed the title
|
@freekmurze please review my pull request again |
|
Seems like it still fails on PHP 8.2 |
|
@freekmurze now the tests will work correctly. we won't be able to support 8.0, 8.1, 8.2 with prefer-lowest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I looked into how queues work in Laravel and found a similar process termination scheme that is very similar to my solution described in issue.
Link to code: this
This is due to the fact that such a constricted system is not able to track upper-level signals by itself.
I also made some improvements, if they need to be moved to a separate pull request, please let me know about it.