Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Convert PHPUnit tests to Pest #167

Merged
merged 7 commits into from
May 11, 2022
Merged

Feature: Convert PHPUnit tests to Pest #167

merged 7 commits into from
May 11, 2022

Conversation

mansoorkhan96
Copy link
Contributor

Hi 👋

This pull request converts PHPUnit tests to Pest.

Thanks for the amazing work, Team Spatie.

freekmurze
freekmurze requested changes May 9, 2022
View reviewed changes
Copy link
Member

@freekmurze freekmurze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! I only got a few nitpicks.

tests/ArrayLogger.php Outdated Show resolved Hide resolved
tests/ImageTest.php Outdated Show resolved Hide resolved
@mansoorkhan96
Copy link
Contributor Author

Hey, @freekmurze I have updated the PR.

@freekmurze
Copy link
Member

It seems like every tests is failing. Please check locally and push a fix.

@mansoorkhan96
Copy link
Contributor Author

mansoorkhan96 commented May 10, 2022 •
edited
Loading

Changes description:

  • Removed type hinting for $message argument in ArrayLogger.php for backward compatibility tests.
  • Updated expectations in OptimizerTest to be in Unix style. (Apologies, I am on Windows and did not notice this issue).
  • Replaced short closure functions with normal functions for backward compatibility tests.

Hopefully, Tests should be fixed now.

Thanks reviewing @freekmurze :)

@mansoorkhan96
Copy link
Contributor Author

Hey, Sir @freekmurze

Does this require further changes? Please let me know when you have time :)

Thanks.

@freekmurze freekmurze merged commit d42e876 into spatie:main May 11, 2022
@freekmurze
Copy link
Member

Looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freekmurze freekmurze Awaiting requested review from freekmurze

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mansoorkhan96 @freekmurze