Add type checking via phpstan #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this one ready to be merged in? |
|
@freekmurze well I'll let that be up to you, the phpstan will fail on it, because of protected and private properties. |
|
btw seems that jetbrains will add support for generics in @mixin soon 👀 https://youtrack.jetbrains.com/issue/WI-64022/Support-mixin-with-template |
|
Let's go for it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added type checking via phpstan, unfortunately it is not flawless as the tests for accessing the protected and private properties fails.
Couldn't really find a way to fix that without having to do a phpstan extension.
To run it