-
-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tap method to ActivityLogger #472
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello,
This feature was missing for me on what i wanted to do, but, now, it's working great.
Thank you !
Just an update, we are running this branch on production right now 😉 Waiting to be merged. |
@Gummibeer looks good 👍 |
@dam1r89 thanks for the feedback. I'm in process to release @freekmurze I've already updated the |
solves: #462
I've done some more things - because I wasn't able to do a
tap()
without an activity model instance I've changed all other methods to also work direct on the model. This has a major change, but not breaking, the properties are set on the model in the moment they are called and not just at the end.I've also cleaned up some things (laravel 5.1 checks, type-hints).
All unit-tests still pass without any change, so I would say that nothing is broken and this just introduces the new feature.