Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only save if has changes #480

Closed
wants to merge 2 commits into from
Closed

Only save if has changes #480

wants to merge 2 commits into from

Conversation

rafwell
Copy link

@rafwell rafwell commented Jan 31, 2019

Fix Issue #435

@Gummibeer
Copy link
Collaborator

Thanks for your work. But I will reject it because:

There is a shouldLog() method which has multiple checks. This addition will destroy multiple functionalities - like you see in the unit tests. For example it's possible to log manual entries without any attributes.

@Gummibeer Gummibeer closed this Jan 31, 2019
@akoSalman
Copy link
Contributor

#514

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants