V4 is getting ready #866
V4 is getting ready #866
Conversation
In addition to: - ⚡ Add missing return types to some functions. - 🎉 Update tests to use the new config object.
🔧 Fix typo in method name on ActivityLog options. 🔀 Merge DetectsChanges trait into LogsActivity. ♻️ Clean some unnecessary helper functions. 📝 Document some behaviours. ✅ Add 2 new tests to demonstrate powerfulness of the pipeline.
✅ Add tests
✅ Add LogBatch Facade. 🚑 Fix code styles and dead methods.
- ✅ Add unit test for UserResolver - ✅ Add couple feature tests - 💚 Add some types and docblocks - 🚀 Ability to resolve user in multiple ways including via callbacks
There was a problem hiding this comment.
One general thing to discuss - should we remove the prefixes from the class names ActivityLog as we already have it in namespace!?
For me this feels like duplication and makes the class names long and not in a good way.
The batch for example - we will never add a second batch class. So Spatie\Activitylog\Batch or similar would be enough I think!?
And even if I have a lot of comments/change-requests in here: amazing work you did here! 🎉🚀 And in such a short time.
- ✅ Drop ActivityLogger prefix - ✅ Resolve @Gummibeer change requests. - ✅ Move to Spatie package tools.
|
@Gummibeer, What is left now is rewrite the docs, I have some ideas, but let's finish the review process first. |
- ✅ Add ability to resolve causer using UUID. - ✅ Fix types.
|
The mentioned missing documentation: please do it in a separated PR - I will merge that one now to the |
|
First draft of the new docs will be ready tonight 🔥🔥 |
withProperties(),withCauser()methods add withXyz() methods #700. Now we can define custom resolver withCauserResolver::resolve()