Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default config - Merge default backup config with user config #1863

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

mho22
Copy link
Contributor

@mho22 mho22 commented Dec 31, 2024

Based on issue #1813.

@Nielsvanpach This is an initial pull request version. I may need further guidance to ensure it is ready for merging.

Copy link
Member

@Nielsvanpach Nielsvanpach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide tests to ensure this works?

@mho22
Copy link
Contributor Author

mho22 commented Jan 3, 2025

@Nielsvanpach I didn't know how you would expect that tests to be implemented so I created a ConfigTest.php file in the tests/Config directory. Let me know if something is missing.

@Nielsvanpach
Copy link
Member

Thanks!

@Nielsvanpach Nielsvanpach merged commit 490f0b5 into spatie:main Jan 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants