Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split up DefaultLogWriter::logRequest() #38

Closed
lsmith77 opened this issue Dec 28, 2020 · 1 comment
Closed

split up DefaultLogWriter::logRequest() #38

lsmith77 opened this issue Dec 28, 2020 · 1 comment

Comments

@lsmith77
Copy link
Contributor

Would you be open a to a PR to split this method by extracting a protected method “getMessage()” that basically does everything except for the call to Log::info()? This would make it feasible to extend the class in case one wants to store the data else where, f.e. in a DB. Potentially there should even be another “formatMessage()” method and “getMessage()” just provides an array of data. what do you think?

https://github.com/spatie/laravel-http-logger/blob/master/src/DefaultLogWriter.php#L12

@freekmurze
Copy link
Member

Feel free to send a PR and I'll consider merging it in 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants