Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

split up default writer #39

Merged
merged 2 commits into from
Jan 4, 2021
Merged

split up default writer #39

merged 2 commits into from
Jan 4, 2021

Conversation

lsmith77
Copy link
Contributor

@lsmith77 lsmith77 commented Jan 2, 2021 •
edited
Loading

see #38

@lsmith77
Copy link
Contributor Author

lsmith77 commented Jan 2, 2021

hmm not so experienced yet with GH, any idea why the tests failed?

@freekmurze
Copy link
Member

There seems to be an undefined variables somewhere: https://github.com/spatie/laravel-http-logger/pull/39/checks?check_run_id=1637118973#step:5:39

@lsmith77
Copy link
Contributor Author

lsmith77 commented Jan 4, 2021

ok looks better now. sorry about that.

@freekmurze freekmurze merged commit c45ab64 into spatie:master Jan 4, 2021
@freekmurze
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lsmith77 @freekmurze