Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add react support (jsx and tsx) #36

Merged
merged 5 commits into from
Jul 10, 2024
Merged

Add react support (jsx and tsx) #36

merged 5 commits into from
Jul 10, 2024

Conversation

fouteox
Copy link
Contributor

@fouteox fouteox commented Jun 22, 2024

Hey, thanks for this package.

Here is support for react and inertia.

I included two versions, a classic jsx and a typescript.

sebastiandedeyne
sebastiandedeyne requested changes Jul 10, 2024
View reviewed changes
Copy link
Member

@sebastiandedeyne sebastiandedeyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! I noted some small code style issues before merging.

resources/ts/LoginLink.tsx Outdated Show resolved Hide resolved
resources/js/LoginLink.jsx Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
resources/ts/LoginLink.tsx Outdated Show resolved Hide resolved
fouteox and others added 4 commits July 10, 2024 09:45
@fouteox @sebastiandedeyne
Update README.md
7a19331 
Co-authored-by: Sebastian De Deyne <sebastiandedeyne@gmail.com>
@fouteox @sebastiandedeyne
Update README.md
04391c7 
Co-authored-by: Sebastian De Deyne <sebastiandedeyne@gmail.com>
@fouteox @sebastiandedeyne
Update resources/ts/LoginLink.tsx
c9f3e12 
Co-authored-by: Sebastian De Deyne <sebastiandedeyne@gmail.com>
@fouteox
fix style code
490a9fe
@fouteox fouteox requested a review from sebastiandedeyne July 10, 2024 07:53
@fouteox
Copy link
Contributor Author

fouteox commented Jul 10, 2024

Thanks for your PR! I noted some small code style issues before merging.

done!

@sebastiandedeyne sebastiandedeyne merged commit 44e3094 into spatie:main Jul 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastiandedeyne sebastiandedeyne sebastiandedeyne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fouteox @sebastiandedeyne