Enable use of RenderedContentInterface and small fix #18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hey @freekmurze - this change makes a quick fix for the 2.0 release related to extensions to help ensure things work properly. There were parts of the initial changes I made that were not covered by tests to catch the logic issue.
Quickfix
Make sure extensions can be given as class names (strings) or instances. So i've made adjustments to ensure extension load properly.
Specifically these lines would be affected:
laravel-markdown/src/MarkdownRenderer.php
Line 149 in 991ff79
laravel-markdown/src/MarkdownRenderer.php
Line 78 in 991ff79
New feature
This also adds a method that mimics the league
convertToHtml
method for users. Adding this method and covering it with tests was what caused me to encounter the error to begin with. Otherwise I would have opted to split them up.This addition is important for users that want the
FrontMatterExtension
(or similar). Since these shouldn't return a string directly like existing methods do. So the new method returns aRenderedContentInterface
object specific to the renderer. For instance, they can use any potential extension specific results. Like: