File versioning

[PHPGuus]

Hi there,

is there appetite for creating a feature in the laravel-medialibrary that will enable file versioning?

I would see this working as any of the starter methods (addMedia and friends) checking whether a file with the given name already exists in the database for the given model, and if so, makes sure that it keeps the previous version in a special "versions" (configurable, of course) subdirectory (much like the subdirectories for media conversions). The main file location would then always have the latest version, but people can retrieve previous versions if they wanted to.

Enabling this feature would be configurable (off, by default) through the media-library.php config file.

Retrieving a specific version of a media would require to add a new argument (say, $version) to the getUrl and other retriever functions to allow a user to (try to) retrieve a particular version of the file.

I would even think, a class FileVersionGenerator could be provided by default that would create version numbers for the versioning implementation. People can then exchange that class with their own implementation, if the standard incremental version numbers (1, 2, etc) are not wanted.

I am more than happy to write this functionality and do a PR etc. I just wanted to see whether the maintainers would be willing to accept this feature into the media-library.

Best regards,
Guus

[freekmurze]

Not too many people has asked for this functionality. I'm a bit hesitant of adding a feature like this as I want to keep this package as simple as possible.

Please do send a PR for this for us to review. If it's something we're willing to maintain we accept it. And if not, you can probably still use the code for your own project.

[PHPGuus]

Hi Freek, OK will do. Thank you!

…

On Thu, Nov 4, 2021 at 10:52 AM Freek Van der Herten < ***@***.***> wrote: Not too many people has asked for this functionality. I'm a bit hesitant of adding a feature like this as I want to keep this package as simple as possible. Please do send a PR for this for us to review. If it's something we're willing to maintain we accept it. And if not, you can probably still use the code for your own project. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2611 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIYQPJOTZZ75U4JI7NLZPJDUKJQXDANCNFSM5FRJSATQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[Forsakenrox]

I request this feature too

[PHPGuus]

Means I've got to find my writer's pen, eh :-)

[dgillier]

Any update on this feature ?
Thanks,
Denis

[sekrap23]

Would love to see this feature done!
Any update on its progress?
Thanks

[fredsal]

I'm actually more than happy to contribute to this feature because it would be a great addition

@SekrapElad hi, any update on its progress?

[sekrap23]

@fredsal No, feel free to make it possible

[fredsal]

I'm actually more than happy to contribute to this feature because it would be a great addition

@SekrapElad If I knew how to do it I would, but since you offer to do it I thought you are making it, and as you say "if there's someone already working on it then surely it's ok if I ask about it"

@fredsal No, feel free to make it possible

any guide or indication, where I can see where you stayed to see if I can add any progress

[sekrap23]

@fredsal Yawnnnnn 🥱 I've much better things to do rather than reply back to your nonsense. Enjoy the rest of your day commenting on threads that have nothing to do with you, sounds really exciting 😘

[fredsal]

lol, demanding something is easy, doing it is not, enjoy the rest of your life demanding on threads that have nothing to do with you, sounds really exciting 😘, bye