Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent error when extracting an image from a video #2904

Merged
merged 1 commit into from
May 3, 2022
Merged

Prevent error when extracting an image from a video #2904

merged 1 commit into from
May 3, 2022

Conversation

prullenbak
Copy link
Contributor

Prevent error when the video is exactly as long (in seconds) as the timestamp set in extractVideoFrameAtSecond()

Prevent error when the video is exactly as long (in seconds) as the timestamp set in extractVideoFrameAtSecond()
@prullenbak
Copy link
Contributor Author

It was a coincidence, but in our case we got errors because a client was uploading a very short video that was exactly as long as our "extractVideoFrameAtSecond"...This prevents that.

@freekmurze freekmurze merged commit b87d8f1 into spatie:main May 3, 2022
@freekmurze
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants