Throw error if disk cannot be accessed #3067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freekmurze
reviewed
Nov 22, 2022
Silver343
commented
Nov 22, 2022
|
@Silver343 Maybe a better approach is to perform a check to see if the disk can be accessed first, and immediately fail if necessary instead of using a transaction. Thoughts? |
|
@Silver343 I've refactored your code to remove the use of database transactions. Are you okay with the changes I made? ping @freekmurze |
|
looks good to me, not sure if the change in return type to add and add remote would be considered breaking changes. |
|
@freekmurze I believe this PR is now ready for review. |
freekmurze
requested changes
Nov 25, 2022
|
@freekmurze To keep this PR moving along and get it merged/closed ASAP, I've pushed the changes you requested to the unit test on behalf of the original PR author (since they were minor). Would you please re-review at your convenience? Thanks! 👍 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the behaviour when a filesytem cannot be accessed as seen in #3010, it will throw and exception and not create a new media record.