Allow to clean orphaned media when the registerMediaConversionsUsingModelInstance
property is set to true
on the model
#3120
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for the
media-library:clean
command.Without the check if the model exists, the
$model->mediaConversions = []
would fail because$model
would benull
.When
$model->registerMediaConversionsUsingModelInstance
is false, the$media->model
check will not execute and not result in an extra query.