Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] Support spatie/pdf-to-image v3 #3633

Merged
merged 4 commits into from
Jun 12, 2024
Merged

Conversation

Jubeki
Copy link
Contributor

@Jubeki Jubeki commented Jun 11, 2024

With the release of spatie/pdf-to-image v3, the spatie media library is no longer compatible with the current implementation.

This PR makes a breaking change by needing v3 instead of v2 and using the corresponding new methods.

@freekmurze
Copy link
Member

I think creating a new major simply for updating the dependency might be a much.

Could you allow for both v2 and v3 to be installed? In code, we should check which version is installed (you can do that with the InstalledVersions class from Composer, and then call the right methods for that version.

This way we can support v3 without making breaking changes.

@Jubeki
Copy link
Contributor Author

Jubeki commented Jun 11, 2024

@freekmurze yeah, will do that!

@Jubeki Jubeki changed the title [12.x][Breaking] Support spatie/pdf-to-image v3 [11.x] Support spatie/pdf-to-image v3 Jun 11, 2024
@Jubeki
Copy link
Contributor Author

Jubeki commented Jun 11, 2024

@freekmurze Do you want a new test workflow for testing v2 and v3 or do you want it with a matrix like I is now?

@freekmurze
Copy link
Member

Like now is fine. Prefer-lowest will pull in v2, prefer-stable v3. That's good enough for me!

@freekmurze freekmurze merged commit d289f81 into spatie:main Jun 12, 2024
9 checks passed
@freekmurze
Copy link
Member

Thank you!

@Jubeki Jubeki deleted the pdf-to-image-v3 branch June 12, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants