Merge pull request #69 from askdkc/main

Fix for publishing view files that has its custom namespace

README.md

@@ -158,6 +158,14 @@ command:
 php artisan vendor:publish --tag=your-package-name-views
 ```
 
+> **Note:**
+> 
+> If you use custom view namespace then you should change your publish command like this:
+```bash
+php artisan vendor:publish --tag=custom-view-namespace-views
+```
+
+
 ### Sharing global data with views
 
 You can share data with all views using the `sharesDataWithAllViews` method. This will make the shared variable

src/PackageServiceProvider.php

@@ -64,8 +64,8 @@ public function boot()
 
             if ($this->package->hasViews) {
                 $this->publishes([
-                    $this->package->basePath('/../resources/views') => base_path("resources/views/vendor/{$this->package->shortName()}"),
-                ], "{$this->package->shortName()}-views");
+                    $this->package->basePath('/../resources/views') => base_path("resources/views/vendor/{$this->packageView($this->package->viewNamespace)}"),
+                ], "{$this->packageView($this->package->viewNamespace)}-views");
             }
 
             $now = Carbon::now();
@@ -195,4 +195,9 @@ protected function getPackageBaseDir(): string
 
         return dirname($reflector->getFileName());
     }
+
+    public function packageView(?string $namespace)
+    {
+        return is_null($namespace) ? $this->package->shortName() : $this->package->viewNamespace;
+    }
 }

tests/PackageServiceProviderTests/PackageViewsWithCustomNamespaceTest.php

@@ -25,9 +25,9 @@ public function it_can_load_the_views_with_a_custom_namespace()
     public function it_can_publish_the_views_with_a_custom_namespace()
     {
         $this
-            ->artisan('vendor:publish --tag=package-tools-views')
+            ->artisan('vendor:publish --tag=custom-namespace-views')
             ->assertExitCode(0);
 
-        $this->assertFileExists(base_path('resources/views/vendor/package-tools/test.blade.php'));
+        $this->assertFileExists(base_path('resources/views/vendor/custom-namespace/test.blade.php'));
     }
 }