Fix migrationFileExists function #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because you have on line 59 variable $migrationFileName without .php and you set it:
```
$this->package->basePath("/../database/migrations/{$migrationFileName}.php.stub") => database_path('migrations/' . now()->format('Y_m_d_His') . '_' . Str::finish($migrationFileName, '.php')),
```
so you must check existing migrations (function migrationFileExists) with .php extension too.
If you don't do that, condition can not work properly, e.g. current functionality return false _te_users_table.php === create_users_table_.
This pull request fix this condition and it will return true __create_users_table.php === create_users_table.php_.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because you have on line 59 variable $migrationFileName without .php and you set it:
so you must check existing migrations (function migrationFileExists) with .php extension too.
If you don't do that, condition can not work properly, e.g. current functionality return false te_users_table.php === create_users_table.
This pull request fix this condition and it will return true _create_users_table.php === create_users_table.php.