Test suite updates

spatie · Dec 3, 2023 · 8ab6bb1 · 8ab6bb1
1 parent 978cf24
commit 8ab6bb1
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/phpunit.xml.dist b/phpunit.xml.dist
@@ -12,7 +12,8 @@
   </testsuites>
   <php>
     <env name="CACHE_DRIVER" value="array"/>
-    <env name="APP_KEY" value="base64:W99w+5JYz8SVGf5sx17gmPR6uoNCtWiEVc+9qu8iGEg="/> <!-- Required for Passport client -->
-    <ini name="memory_limit" value="512M" />
+    <!-- APP_KEY required for Passport client -->
+    <env name="APP_KEY" value="base64:W99w+5JYz8SVGf5sx17gmPR6uoNCtWiEVc+9qu8iGEg="/>
+    <ini name="memory_limit" value="512M"/>
   </php>
 </phpunit>
diff --git a/tests/RoleWithNestingTest.php b/tests/RoleWithNestingTest.php
@@ -10,10 +10,10 @@ class RoleWithNestingTest extends TestCase
     protected $useCustomModels = true;
 
     /** @var Role[] */
-    protected $parent_roles = [];
+    protected array $parent_roles = [];
 
     /** @var Role[] */
-    protected $child_roles = [];
+    protected array $child_roles = [];
 
     protected function setUp(): void
     {
@@ -67,7 +67,7 @@ public function it_returns_correct_withCount_of_nested_roles($role_group, $index
         $role = $this->$role_group[$index];
         $count_field_name = sprintf('%s_count', $relation);
 
-        $actualCount = intval(Role::withCount($relation)->find($role->getKey())->$count_field_name);
+        $actualCount = (int)Role::withCount($relation)->find($role->getKey())->$count_field_name;
 
         $this->assertSame(
             $expectedCount,
@@ -76,7 +76,7 @@ public function it_returns_correct_withCount_of_nested_roles($role_group, $index
         );
     }
 
-    public function roles_list()
+    public static function roles_list()
     {
         return [
             ['parent_roles', 'has_no_children', 'children', 0],