code reformatting

[angeljqv]

Php 7.4 sintax
Support id/uuid on enums, for consistency with the rest
use is_int instead of is_numeric, ids must be int

laravel-permission/src/Traits/HasPermissions.php

Line 169 in 38f2049

if (is_int($permission) || is_string($permission)) {

laravel-permission/src/Traits/HasPermissions.php

Line 212 in 38f2049

if (is_int($permission) || PermissionRegistrar::isUid($permission)) {

laravel-permission/src/Traits/HasRoles.php

Line 218 in 38f2049

if (is_int($roles) || is_string($roles)) {

[angeljqv]

@drbyte any reason not to make squash commits? It would be easier to read the commit history

[drbyte]

squash commits

In a PR, yes please squash and force push commits that canonically go together. Multiple commits are fine if they're about different things. Sometimes that warrants a separate PR, but not always.

[angeljqv]

sorry, I didn't explain myself correctly, I was referring to squash merge, look 38f2049
on squash merge commits is easy to read, look spatie/laravel-medialibrary@79b7295
so the history is more linear

[drbyte]

sorry, I didn't explain myself correctly, I was referring to squash merge, look 38f2049
on squash merge commits is easy to read, look spatie/laravel-medialibrary@79b7295
so the history is more linear

I still don't understand what you're asking about. PR #2402 (commit 38f2049 ) had only one commit. Nothing to squash when merging.
Please feel free to explain further.

[drbyte]

@angeljqv I see what you mean. Thanks for clarifying.