Add findOrFail #11
Merged
Add findOrFail #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freekmurze
requested changes
Sep 29, 2021
| return new static("Could not find a prefixed model `{$prefixedId}`"); | ||
| } | ||
|
|
||
| public function getSolution(): Solution |
Contributor
|
I'm thinking it might be better to throw Laravel's ModelNotFoundException, as this gets handled into a 404 correctly by default in Laravel. throw (new ModelNotFoundException())->setModel(static::class);What do you think @freekmurze? |
Contributor
Author
|
@riasvdv I was using Wouldn't it be possible to extend This would make it possible to listen for both exceptions, right? :) |
Member
|
Thanks! |
Contributor
Author
|
@freekmurze Thanks for the merge. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.