-
-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] add filter by operator #940
Conversation
@AbdelrahmanBl is it possible to pass the operator through query parameters? |
It's really a great idea!
|
Hello sir! How are you? Can you check this feature? |
@AbdelrahmanBl Please stop deleting your previous comment and @ people. No doubt they're busy and they'll get to it when they get to it. |
Thank you for your response 🙏 and i won't contribute with spatie anymore for not annoying them. |
I'm not from Spatie, just someone whose inbox you were spamming. Repeatedly @ing anyone isn't productive be it Spatie or anyone else. I'd subscribed to the thread because i'm interested in the feature as I'm sure others are too. Closing it because someone suggest you be patient seems overkill, but it is your PR to do what you will with. |
I thought you were from spatie and no problem i will reopen it to benefit the others 😊 |
@freekmurze kindly check this commit! |
Hi @freekmurze, This improvement could be considered to be released. I mean, it's a good feature, I don't understand why not implement the feature. Are there some pending considerations? Or Do you want to implement this feature in another way? It will be great to know it. Thanks |
Could you update the readme with clear examples on how to use this? |
Hi @AbdelrahmanBl , Could you generate the requested documentation? We are close to get merge this pr 😄 |
@cgarciagarcia |
Hello @AbdelrahmanBl , I would like to know if there are posibilities to include the documententation that freekmurze requested to merge this PR. I like your feature and I think it's a good resolution approach. |
Thanks everyone for your input and hard work! I'll add docs for this feature and tag it as a new feature release. |
@AbdelrahmanBl thank you |
thanks guys, i'm very busy nowadays and that is the reason for not completing the doc |
Thanks @AbdelrahmanBl for your work! and spatie team for your care. |
Dear sir
I had been developed out of the box a method for filtering by operator.
for the example: