Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ability to filter models by an array as filter value #943

Merged
merged 1 commit into from
May 21, 2024

Conversation

inmula
Copy link
Contributor

@inmula inmula commented May 21, 2024

In commit 9e68f80 filtering models by an array as a filter value was broken. This is confirmed by the tests that are failing: https://github.com/spatie/laravel-query-builder/actions/runs/9029978604/job/24813361498

This PR restores the original behaviour while keeping PHPstan happy.

@freekmurze freekmurze merged commit 69a6fd3 into spatie:main May 21, 2024
1 check passed
@freekmurze
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants