ADD: down method to migration file

[mrmmg]

Hi,

I recently installed this package and when I run the php artisan migrate:refresh command, Laravel throws an exception that the settings table already exists. The issue is that the migration does not include a down method, so the settings table is not removed in migration refresh. So, I added the down method to it.

Let me know if you'd like me to suggest any further changes!

[rubenvanassche]

We don't use down migrations in any package / project.

99.9% of the time you are not gonna use a down migration and you’re probably never testing them. Just write an up migration if you want to drop a column again. 👍

[mrmmg]

We don't use down migrations in any package / project.

99.9% of the time you are not gonna use a down migration and you’re probably never testing them. Just write an up migration if you want to drop a column again. 👍

That's incorrect! In Laravel Package, you typically publish your migration files to the database/migrations folder. Based on your thought, if I want to define another migration, I would need to create a dummy migration and change the file name, since Laravel loads migration files based on their names. However, I believe this approach is not ideal for removing the settings table. Am I correct?"