Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore customization of placeholder #11

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

RoccoHoward
Copy link
Contributor

@RoccoHoward RoccoHoward commented Aug 2, 2024

Localization broke the ability to customize the placeholder.

Moving the placeholder setOptions after localization restores this functionality.

This maintains the ability to use the default placeholder value with localization.

Localization broke the ability to customize the placeholder. Moving the placeholder being set to after localization restores this functionality.
@RoccoHoward
Copy link
Contributor Author

RoccoHoward commented Aug 2, 2024

See issue being raised here #10

@riasvdv riasvdv merged commit 7a5c33b into spatie:main Sep 20, 2024
1 check passed
@riasvdv
Copy link
Member

riasvdv commented Sep 20, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants