Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable or disable revert methods #19

Closed
wants to merge 1 commit into from

Conversation

KhairulAzmi21
Copy link
Contributor

@KhairulAzmi21 KhairulAzmi21 commented Sep 27, 2024

I would love if we can enable or disable revert .

Would be better UX , when user click button cancel we remove the image , rathen then needing of click cancel button twice in order to remove the file .

With revert false

with.revert.true.mov

With revert true

with.revert.false.mov

@@ -64,7 +67,7 @@ class="{{ $attributes->get('class') }}"
$dispatch('filepond-upload-finished', {'{{ $wireModelAttribute }}': response });
}, error, progress);
},
revert: async (filename, load) => {
revert: allowRevert ? './revert' : async (filename, load) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this ./revert do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually it was end point to /revert .

should I put it null instead ?

@riasvdv
Copy link
Member

riasvdv commented Nov 22, 2024

Going to close this as I'd like to keep the current functionality for now

@riasvdv riasvdv closed this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants