Remove depreciated option from phpstan.neon.dist #337
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove checkMissingIterableValueType option since it is depreceated
With
checkMissingIterableValueType: false
in the config, i get the following output:So, I replaced
checkMissingIterableValueType: false
with the following:But then, I get a new error:
❯ vendor/bin/phpstan Note: Using configuration file path/to/project/phpstan.neon.dist. 6/6 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100% -- ------------------------------------------------------------------------------------- Error -- ------------------------------------------------------------------------------------- Ignored error pattern missingType.iterableValue was not matched in reported errors. -- -------------------------------------------------------------------------------------
It seemed like that option was irrelevant for a new project created with this skeleton.
Also, from phpstan docs, missing typehints are checked from
Level: 6
, irrelevant for our config ofLevel: 5
https://phpstan.org/config-reference#vague-typehints
So, I thought it would be better to remove it from the skeleton as users can add it later if they want.