Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace passthru with echo #133

Merged
merged 1 commit into from
Feb 26, 2021
Merged

Conversation

wilmardo
Copy link
Contributor

@wilmardo wilmardo commented Feb 25, 2021

passthru is disabled in most security oriented PHP setups since it allows shell access.

I replaced it with native PHP echo and locally my terminal gets cleared perfectly, what was the reason to do this with echo?

Signed-off-by: wilmardo <info@wilmardenouden.nl>
@wilmardo
Copy link
Contributor Author

Hmm the CI failures seem unrelated to my changes:

There were 2 errors:

1) Spatie\PhpUnitWatcher\Test\WatcherFactoryTest::setting_notification_preserves_other_options
Error: Call to undefined method Symfony\Component\Finder\Finder::ignoreVCSIgnored()

/home/runner/work/phpunit-watcher/phpunit-watcher/src/WatcherFactory.php:24
/home/runner/work/phpunit-watcher/phpunit-watcher/tests/WatcherFactoryTest.php:27

2) Spatie\PhpUnitWatcher\Test\WatcherFactoryTest::setting_directories_preserves_other_options
Error: Call to undefined method Symfony\Component\Finder\Finder::ignoreVCSIgnored()

/home/runner/work/phpunit-watcher/phpunit-watcher/src/WatcherFactory.php:24
/home/runner/work/phpunit-watcher/phpunit-watcher/tests/WatcherFactoryTest.php:44

@freekmurze Are these known errors?

@wilmardo wilmardo changed the title fix: replace passthru with print fix: replace passthru with echo Feb 25, 2021
@freekmurze freekmurze merged commit 67b74c1 into spatie:master Feb 26, 2021
@freekmurze
Copy link
Member

Thanks, I'll fix the tests myself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants