Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Addressing file_exists null arg deprecation. #139

Merged
merged 1 commit into from
Dec 17, 2021

Conversation

binaryk
Copy link
Contributor

@binaryk binaryk commented Nov 30, 2021

PHP8.1 complains about this:

image

@flexchar
Copy link

LGTM

@@ -15,7 +15,7 @@ jobs:
- name: Run PHP CS Fixer
uses: docker://oskarstark/php-cs-fixer-ga
with:
args: --config=.php_cs.dist --allow-risky=yes
args: --config=.php_cs.dist.php --allow-risky=yes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious, is this a necessary change?

@freekmurze freekmurze merged commit 74a6328 into spatie:master Dec 17, 2021
@freekmurze
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants