-
-
Notifications
You must be signed in to change notification settings - Fork 17
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Extract creating disallowed objects into respective factories
- Loading branch information
Showing
33 changed files
with
189 additions
and
102 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
<?php | ||
declare(strict_types = 1); | ||
|
||
namespace Spaze\PHPStan\Rules\Disallowed; | ||
|
||
use PHPStan\ShouldNotHappenException; | ||
|
||
class DisallowedCallFactory | ||
{ | ||
|
||
/** | ||
* @param array $config | ||
* @phpstan-param ForbiddenCallsConfig $config | ||
* @noinspection PhpUndefinedClassInspection ForbiddenCallsConfig is a type alias defined in PHPStan config | ||
* @return DisallowedCall[] | ||
* @throws ShouldNotHappenException | ||
*/ | ||
public function createFromConfig(array $config): array | ||
{ | ||
$calls = []; | ||
foreach ($config as $disallowedCall) { | ||
$call = $disallowedCall['function'] ?? $disallowedCall['method'] ?? null; | ||
if (!$call) { | ||
throw new ShouldNotHappenException("Either 'method' or 'function' must be set in configuration items"); | ||
} | ||
$disallowedCall = new DisallowedCall( | ||
$call, | ||
$disallowedCall['message'] ?? null, | ||
$disallowedCall['allowIn'] ?? [], | ||
$disallowedCall['allowParamsInAllowed'] ?? [], | ||
$disallowedCall['allowParamsAnywhere'] ?? [], | ||
$disallowedCall['allowExceptParams'] ?? [], | ||
$disallowedCall['allowExceptCaseInsensitiveParams'] ?? [] | ||
); | ||
$calls[$disallowedCall->getKey()] = $disallowedCall; | ||
} | ||
return array_values($calls); | ||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
<?php | ||
declare(strict_types = 1); | ||
|
||
namespace Spaze\PHPStan\Rules\Disallowed; | ||
|
||
use PHPStan\ShouldNotHappenException; | ||
|
||
class DisallowedConstantFactory | ||
{ | ||
|
||
/** | ||
* @param array<array{class?:string, constant?:string, message?:string, allowIn?:string[]}> $config | ||
* @return DisallowedConstant[] | ||
* @throws ShouldNotHappenException | ||
*/ | ||
public function createFromConfig(array $config): array | ||
{ | ||
$constants = []; | ||
foreach ($config as $disallowedConstant) { | ||
$constant = $disallowedConstant['constant'] ?? null; | ||
if (!$constant) { | ||
throw new ShouldNotHappenException("'constant' must be set in configuration items"); | ||
} | ||
$class = $disallowedConstant['class'] ?? null; | ||
$disallowedConstant = new DisallowedConstant( | ||
$class ? "{$class}::{$constant}" : $constant, | ||
$disallowedConstant['message'] ?? null, | ||
$disallowedConstant['allowIn'] ?? [] | ||
); | ||
$constants[$disallowedConstant->getConstant()] = $disallowedConstant; | ||
} | ||
return array_values($constants); | ||
} | ||
|
||
} |
Oops, something went wrong.