Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not add ", because reasons" when no message is defined #220

Closed
ruudk opened this issue Nov 20, 2023 · 2 comments · Fixed by #221
Closed

Do not add ", because reasons" when no message is defined #220

ruudk opened this issue Nov 20, 2023 · 2 comments · Fixed by #221

Comments

@ruudk
Copy link
Contributor

ruudk commented Nov 20, 2023

I don't like nullability either, but having ", because reasons" being appended by default looks weird and doesn't make sense to me.

Why not leave it out and end the sentence with a period?

-Namespace Doctrine\ORM\Mapping\OneToOne is forbidden, because reasons
+Namespace Doctrine\ORM\Mapping\OneToOne is forbidden.
@spaze
Copy link
Owner

spaze commented Nov 20, 2023

Yeah, it's weird but it's there to encourage adding your own message because the default one doesn't make much sense 😅 But I'll see, maybe it could be changed, or made configurable.

@spaze spaze mentioned this issue Nov 26, 2023
Merged
spaze added a commit that referenced this issue Nov 28, 2023
@spaze
Remove "because reasons", because reasons (#221)
4b952b1 
Was funny back then but maybe it's not anymore. Also it doesn't really indicate that the message could be changed. Also, the message will always end with a `.`, unless it ends with `?` or `!` already. Sorry if it breaks things for you, should have done this much earlier.

Close #220
@ruudk
Copy link
Contributor Author

ruudk commented Dec 1, 2023

Thanks for fixing this. It's a small thing, but it makes it nicer! 💙

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove "because reasons", because reasons spaze/phpstan-disallowed-calls
2 participants
@ruudk @spaze