Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disallowedAttributes: configure errorIdentifier and errorTip as optional #229

Merged

Conversation

francescolaffi
Copy link
Contributor

@francescolaffi francescolaffi commented Dec 11, 2023

Gave a test run of some disallowed attributes on properties after #225 , noticed errorIdentifier and errorTip are considered mandatory but I'm guessing it was not intended in #222

Additionally aligned some comments on recently introduced tests (if I got correctly the meaning)

@spaze spaze force-pushed the disallowed-attributes-optional-parameters branch from fc934b2 to e4c2297 Compare December 12, 2023 05:18
@spaze
Copy link
Owner

spaze commented Dec 12, 2023

Nice catch in the parametersSchema, thanks! This was indeed a strange copy/paste bug or something, definitely not intended. I've replaced the test update with #230, I didn't like the two classes be the same except the class name and the comments (which were wrong 😅), it has actually confused me before so thanks for forcing me (in a kindly way) to do something with that.

@spaze spaze merged commit a6ceaaa into spaze:main Dec 12, 2023
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants