Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copied and modified original implementation from Haven. #1

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Conversation

canismarko
Copy link
Contributor

Description

This project was started as part of the spectroscopy group's Haven package. This copies the code from haven to guarneri.

Probably not functional just yet.

Motivation and Context

Just want some code available as a jumping off point.

How Has This Been Tested?

Added tests that duplicate the functionality in the spc-group with dummy devices. Has been used successfully at 25-ID-C/D. Not tested for usability outside of these beamlines.

Where Has This Been Documented?

Some docstrings, but we definitely could use more documentation.

@canismarko canismarko added the enhancement New feature or request label Oct 21, 2024
Copy link
Collaborator

@MDecarabas MDecarabas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@canismarko canismarko merged commit f3e2c70 into main Oct 23, 2024
3 checks passed
@canismarko canismarko deleted the hoist branch October 23, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants