Add map split transformation #1654
Open
+170
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't like the name too much, maybe someone has a better idea.
This transformation covers some cases found in climate codes where the range of a nested map changes on the first and/or the last iteration of an outer map. The resulting SDFG has a map with a nested sdfg, where multiple states are needed to calculate the correct inner range, preventing map collapse.
The transformation will look for such a pattern and split the map accordingly, in order to simplify the nested SDFG that can be later inlined after simplification (atm covering only a simple equality when detecting the condition, and peeling only one iteration).
Note that due to a bug, the resulting SDFG is wrong. The
python-frontend-dealias-integrationsolves the bug.example before:
after:
after simplify:
