Add GoLang support for benchmarks #247

MahadMuhammad · 2025-03-23T08:00:49Z

Fix bug in supported_language_versions function.
Add Docker base image for GoLang
Add Dockerfile.build for multiple platforms
Add golang_installer.sh
Add benchmarks wrappers for multiple platforms
Update launching code

coderabbitai · 2025-03-23T08:00:56Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

…ource and fix typo

…or consistency

…ment

mcopik · 2025-05-09T15:40:49Z

dockerfiles/aws/golang/Dockerfile.build

+    && chmod +x /usr/local/bin/gosu
+
+# Download and install Go
+RUN wget -q "https://go.dev/dl/go${GO_VERSION}.linux-${TARGETARCH}.tar.gz" -O go.tar.gz && \


If the base image is amazon/aws-lambda-go:1.2024.10.04.19, then do we need to install Go separately?

mcopik · 2025-05-09T15:54:55Z

dockerfiles/golang_installer.sh

+
+cd /mnt/function
+go mod init github.com/spcl/serverless-benchmarks
+go get github.com/minio/minio-go/v7


We only need that for the local deployment—this should be installed as a "storage" module; see the example for Python. Depending on the enabled storage options and the cloud system, these packages should be added during deployment. In case of Python, we append new packages to requirements.txt - https://github.com/spcl/serverless-benchmarks/blob/master/sebs/benchmark.py#L361

mcopik · 2025-05-09T15:55:01Z

dockerfiles/golang_installer.sh

+#!/bin/bash
+
+cd /mnt/function
+go mod init github.com/spcl/serverless-benchmarks


Why is this necessary?

mcopik · 2025-05-09T15:55:30Z

sebs/benchmark.py

@@ -399,13 +401,18 @@ def add_deployment_package_nodejs(self, output_dir):
            with open(package_config, "w") as package_file:
                json.dump(package_json, package_file, indent=2)

+    def add_deployment_package_golang(self, output_dir):
+        pass


Here we should add system-dependent packages :)

MahadMuhammad added 2 commits March 23, 2025 07:02

Add Go configuration for base images and deployment settings

5991756

Add Go Dockerfiles for multiple platform builds and add installer script

6eeb393

MahadMuhammad added 4 commits March 23, 2025 08:04

Add Golang in Docker build scripts

79acf69

Add go installation from official website and successful image build

99af2d1

Fix typo "go" to "golang" in systems configuration for consistency

6882cf5

Update aws, azure, gcp, and openwhisk go installation from official s…

b423937

…ource and fix typo

MahadMuhammad force-pushed the golang-support branch from 2b6b2f0 to b423937 Compare May 2, 2025 07:16

MahadMuhammad added 2 commits May 2, 2025 11:57

Update Go version handling in Dockerfiles and systems configuration f…

43b4729

…or consistency

Add Golang storage implementation and update configuration for deploy…

ff6d40d

…ment

MahadMuhammad force-pushed the golang-support branch from b641711 to ff6d40d Compare May 2, 2025 13:44

mcopik requested changes May 9, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add GoLang support for benchmarks #247

Add GoLang support for benchmarks #247

Uh oh!

MahadMuhammad commented Mar 23, 2025

Uh oh!

coderabbitai bot commented Mar 23, 2025 •

edited

Loading

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

mcopik May 9, 2025

Uh oh!

mcopik May 9, 2025

Uh oh!

mcopik May 9, 2025

Uh oh!

mcopik May 9, 2025

Uh oh!

Uh oh!

Add GoLang support for benchmarks #247

Are you sure you want to change the base?

Add GoLang support for benchmarks #247

Uh oh!

Conversation

MahadMuhammad commented Mar 23, 2025

Uh oh!

coderabbitai bot commented Mar 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

mcopik May 9, 2025

Choose a reason for hiding this comment

Uh oh!

mcopik May 9, 2025

Choose a reason for hiding this comment

Uh oh!

mcopik May 9, 2025

Choose a reason for hiding this comment

Uh oh!

mcopik May 9, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai bot commented Mar 23, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)