support volume expansion #16

lijhnihaoa · 2022-09-28T12:12:47Z

I would like to ask what you think about the high availability of CSI. For example, if SPDK and CSI-Node are restarted at the same time, how can they be restored to the state before the restart.

cyb70289 · 2022-09-29T01:04:11Z

No strong feeling from me. But welcome contributions.

lijhnihaoa · 2022-09-29T02:40:51Z

I wonder if storing this information in etcd will affect the impact of the k8s cluster, if it is used in the actual production environment. etcd is generally the best memory in 8G, Too big or too small can easily cause performance degradation.I feel that my question is a bit redundant, but I still want to hear more professional opinions.

lijhnihaoa · 2022-09-29T03:22:56Z

If I want to contribute the code of expand volume, what should I do?

cyb70289 · 2022-09-29T03:46:37Z

You can follow the guide in below link to setup gerrit and push code.
https://spdk.io/development/
Please note the guide refers to spdk repo, the spdk-csi repo is at https://review.spdk.io/spdk/spdk-csi.

lijhnihaoa · 2022-10-11T01:42:35Z

To https://review.spdk.io/spdk/spdk-csi ! [remote rejected] HEAD -> refs/for/master (commit de65fdf: not Signed-off-by author/committer/uploader in message footer) error: failed to push some refs to 'https://review.spdk.io/spdk/spdk-csi' What should I do?

cyb70289 · 2022-10-11T02:03:17Z

not Signed-off-by author/committer/uploader in message footer

Try git commit --amend -s to add sign-off-by line.

lijhnihaoa · 2022-10-11T02:47:13Z

nice

lijhnihaoa · 2022-10-13T02:29:43Z

How often submitted code is generally evaluated

cyb70289 · 2022-10-13T02:35:47Z

I've left comment to your PR yesterday.
Normally there will be response in a week. Not guaranteed if reviewer is busy or simply missed your patch.
If you'd like it to be faster, join spdk slack channel and ping reviewers directly. Comments in gerrit are often ignored by reviewers.
https://spdk.io/community/

lijhnihaoa · 2022-10-13T02:47:27Z

thank you . i got it

cyb70289 · 2022-10-13T02:52:56Z

For a major feature, there's often non-trivial feed backs and change request to the original commit.

lijhnihaoa · 2022-10-13T02:59:07Z

I think mine is a secondary feature, haha.

lijhnihaoa · 2023-04-24T08:51:02Z

root@localhost:~/go/src/spdk-csi# git status
On branch master
Your branch is up to date with 'origin/master'.

Changes not staged for commit:
(use "git add ..." to update what will be committed)
(use "git restore ..." to discard changes in working directory)
modified: pkg/spdk/controllerserver.go
modified: pkg/util/iscsi.go
modified: pkg/util/iscsi_test.go
modified: pkg/util/jsonrpc.go
modified: pkg/util/nvmf.go
modified: pkg/util/nvmf_test.go
root@localhost:/go/src/spdk-csi# make test
=== runnng go mod verify
all modules verified
=== running unit test
? github.com/spdk/spdk-csi/cmd [no test files]
? github.com/spdk/spdk-csi/pkg/csi-common [no test files]
ok github.com/spdk/spdk-csi/pkg/spdk 6.478s coverage: 24.4% of statements
ok github.com/spdk/spdk-csi/pkg/util 1.410s coverage: 47.8% of statements
root@localhost:/go/src/spdk-csi#

I added functionality for volume expansion and performed unit tests. This indicate that the test passed?

lijhnihaoa · 2023-04-24T08:53:56Z

iSCSI:
{\"jsonrpc\":\"2.0\",\"id\":4,\"method\":\"iscsi_get_portal_groups\"} {\"jsonrpc\":\"2.0\",\"id\":4,\"result\":[{\"tag\":1,\"portals\":[{\"host\":\"127.0.0.1\",\"port\":\"3260\"}],\"private\":false}]}\n 127.0.0.1 - - [24/Apr/2023 08:48:30] "POST / HTTP/1.1" 200 - {\"jsonrpc\":\"2.0\",\"id\":5,\"method\":\"iscsi_get_initiator_groups\"} {\"jsonrpc\":\"2.0\",\"id\":5,\"result\":[{\"tag\":1,\"initiators\":[\"ANY\"],\"netmasks\":[\"ANY\"]}]}\n 127.0.0.1 - - [24/Apr/2023 08:48:30] "POST / HTTP/1.1" 200 - {\"jsonrpc\":\"2.0\",\"id\":6,\"method\":\"iscsi_create_target_node\",\"params\":{\"luns\":[{\"lun_id\":0,\"bdev_name\":\"9fda7a14-f428-484d-8018-d67b2123e279\"}],\"name\":\"9fda7a14-f428-484d-8018-d67b2123e279\",\"alias_name\":\"iscsi-9fda7a14-f428-484d-8018-d67b2123e279\",\"pg_ig_maps\":[{\"ig_tag\":1,\"pg_tag\":1}],\"disable_chap\":true,\"queue_depth\":64}} {\"jsonrpc\":\"2.0\",\"id\":6,\"result\":true}\n 127.0.0.1 - - [24/Apr/2023 08:48:30] "POST / HTTP/1.1" 200 - {\"jsonrpc\":\"2.0\",\"id\":7,\"method\":\"iscsi_get_target_nodes\"} {\"jsonrpc\":\"2.0\",\"id\":7,\"result\":[{\"name\":\"iqn.2016-06.io.spdk:9fda7a14-f428-484d-8018-d67b2123e279\",\"alias_name\":\"iscsi-9fda7a14-f428-484d-8018-d67b2123e279\",\"pg_ig_maps\":[{\"pg_tag\":1,\"ig_tag\":1}],\"luns\":[{\"bdev_name\":\"9fda7a14-f428-484d-8018-d67b2123e279\",\"lun_id\":0}],\"queue_depth\":64,\"disable_chap\":true,\"require_chap\":false,\"mutual_chap\":false,\"chap_group\":0,\"header_digest\":false,\"data_digest\":false}]}\n 127.0.0.1 - - [24/Apr/2023 08:48:30] "POST / HTTP/1.1" 200 - {\"jsonrpc\":\"2.0\",\"id\":8,\"method\":\"bdev_lvol_resize\",\"params\":{\"name\":\"9fda7a14-f428-484d-8018-d67b2123e279\",\"size\":1069547520}} {\"jsonrpc\":\"2.0\",\"id\":8,\"result\":true}\n

nvmf:
{\"jsonrpc\":\"2.0\",\"id\":4,\"method\":\"nvmf_create_transport\",\"params\":{\"trtype\":\"TCP\"}} {\"jsonrpc\":\"2.0\",\"id\":4,\"error\":{\"code\":-32603,\"message\":\"Transport type 'TCP' already exists\"}}\n 127.0.0.1 - - [24/Apr/2023 08:48:31] "POST / HTTP/1.1" 200 - {\"jsonrpc\":\"2.0\",\"id\":5,\"method\":\"nvmf_create_subsystem\",\"params\":{\"nqn\":\"nqn.2020-04.io.spdk.csi:uuid:adb8bfad-29ad-41da-b134-37c28bd8f6e9\",\"allow_any_host\":true,\"serial_number\":\"spdkcsi-sn\",\"model_number\":\"adb8bfad-29ad-41da-b134-37c28bd8f6e9\"}} {\"jsonrpc\":\"2.0\",\"id\":5,\"result\":true}\n 127.0.0.1 - - [24/Apr/2023 08:48:31] "POST / HTTP/1.1" 200 - {\"jsonrpc\":\"2.0\",\"id\":6,\"method\":\"nvmf_subsystem_add_ns\",\"params\":{\"nqn\":\"nqn.2020-04.io.spdk.csi:uuid:adb8bfad-29ad-41da-b134-37c28bd8f6e9\",\"namespace\":{\"bdev_name\":\"adb8bfad-29ad-41da-b134-37c28bd8f6e9\"}}} {\"jsonrpc\":\"2.0\",\"id\":6,\"result\":1}\n 127.0.0.1 - - [24/Apr/2023 08:48:31] "POST / HTTP/1.1" 200 - {\"jsonrpc\":\"2.0\",\"id\":7,\"method\":\"nvmf_subsystem_add_listener\",\"params\":{\"nqn\":\"nqn.2020-04.io.spdk.csi:uuid:adb8bfad-29ad-41da-b134-37c28bd8f6e9\",\"listen_address\":{\"trtype\":\"TCP\",\"adrfam\":\"IPv4\",\"traddr\":\"127.0.0.1\",\"trsvcid\":\"4420\"}}} {\"jsonrpc\":\"2.0\",\"id\":7,\"result\":true}\n 127.0.0.1 - - [24/Apr/2023 08:48:31] "POST / HTTP/1.1" 200 - {\"jsonrpc\":\"2.0\",\"id\":8,\"method\":\"nvmf_get_subsystems\"} {\"jsonrpc\":\"2.0\",\"id\":8,\"result\":[{\"nqn\":\"nqn.2014-08.org.nvmexpress.discovery\",\"subtype\":\"Discovery\",\"listen_addresses\":[],\"allow_any_host\":true,\"hosts\":[]},{\"nqn\":\"nqn.2020-04.io.spdk.csi:uuid:adb8bfad-29ad-41da-b134-37c28bd8f6e9\",\"subtype\":\"NVMe\",\"listen_addresses\":[{\"transport\":\"TCP\",\"trtype\":\"TCP\",\"adrfam\":\"IPv4\",\"traddr\":\"127.0.0.1\",\"trsvcid\":\"4420\"}],\"allow_any_host\":true,\"hosts\":[],\"serial_number\":\"spdkcsi-sn\",\"model_number\":\"adb8bfad-29ad-41da-b134-37c28bd8f6e9\",\"max_namespaces\":32,\"min_cntlid\":1,\"max_cntlid\":65519,\"namespaces\":[{\"nsid\":1,\"bdev_name\":\"adb8bfad-29ad-41da-b134-37c28bd8f6e9\",\"name\":\"adb8bfad-29ad-41da-b134-37c28bd8f6e9\",\"nguid\":\"ADB8BFAD29AD41DAB13437C28BD8F6E9\",\"uuid\":\"adb8bfad-29ad-41da-b134-37c28bd8f6e9\"}]},{\"nqn\":\"nqn.2020-04.io.spdk.csi:uuid:88388769-a0ea-4656-a19d-5d4cbcb5fd3c\",\"subtype\":\"NVMe\",\"listen_addresses\":[{\"transport\":\"TCP\",\"trtype\":\"TCP\",\"adrfam\":\"IPv4\",\"traddr\":\"127.0.0.1\",\"trsvcid\":\"4420\"}],\"allow_any_host\":true,\"hosts\":[],\"serial_number\":\"spdkcsi-sn\",\"model_number\":\"88388769-a0ea-4656-a19d-5d4cbcb5fd3c\",\"max_namespaces\":32,\"min_cntlid\":1,\"max_cntlid\":65519,\"namespaces\":[]}]}\n 127.0.0.1 - - [24/Apr/2023 08:48:31] "POST / HTTP/1.1" 200 - {\"jsonrpc\":\"2.0\",\"id\":9,\"method\":\"bdev_lvol_resize\",\"params\":{\"name\":\"adb8bfad-29ad-41da-b134-37c28bd8f6e9\",\"size\":1069547520}} {\"jsonrpc\":\"2.0\",\"id\":9,\"result\":true}\n

cyb70289 · 2023-04-24T08:56:47Z

Not sure of your question. Do you add volume expansion specific unit test? The test itself should verify the function.

lijhnihaoa · 2023-04-24T09:17:01Z

Not sure of your question. Do you add volume expansion specific unit test? The test itself should verify the function.

Yes, Can the above output prove that the function is feasible. i think it's ok， bdev_lvol_resize return is true.

cyb70289 · 2023-04-24T09:25:49Z

Honestly, it's hard for me to read the above output.
If you want to make sure the volume size is successfully changed, you can read back and verify the size with bdev_get_bdevs.

lijhnihaoa · 2023-04-24T09:33:00Z

{"jsonrpc":"2.0","id":9,"method":"bdev_lvol_resize","params":{"name":"adb8bfad-29ad-41da-b134-37c28bd8f6e9","size":1069547520}}
{"jsonrpc":"2.0","id":9,"result":true}\n
127.0.0.1 - - [24/Apr/2023 08:48:31] "POST / HTTP/1.1" 200 -
{"jsonrpc":"2.0","id":10,"method":"bdev_get_bdevs","params":{"name":"adb8bfad-29ad-41da-b134-37c28bd8f6e9"}}
{"jsonrpc":"2.0","id":10,"result":[{"name":"adb8bfad-29ad-41da-b134-37c28bd8f6e9","aliases":["lvs0/csi-13dc1d37-9ff8-485a-b253-1ca453b1bb6e"],"product_name":"Logical Volume","block_size":4096,"num_blocks":261120,"uuid":"adb8bfad-29ad-41da-b134-37c28bd8f6e9","assigned_rate_limits":{"rw_ios_per_sec":0,"rw_mbytes_per_sec":0,"r_mbytes_per_sec":0,"w_mbytes_per_sec":0},"claimed":true,"zoned":false,"supported_io_types":{"read":true,"write":true,"unmap":true,"write_zeroes":true,"flush":false,"reset":true,"compare":false,"compare_and_write":false,"abort":false,"nvme_admin":false,"nvme_io":false},"driver_specific":{"lvol":{"lvol_store_uuid":"4817477f-1a73-4620-b64a-da82c2d036a7","base_bdev":"Malloc0","thin_provision":true,"snapshot":false,"clone":false}}}]}\n

Sorry, I didn't think carefully. The above may be the key information.

cyb70289 · 2023-04-24T09:38:27Z

This looks right. Of course, you should make sure the original size is not the same as resized.

lijhnihaoa · 2023-04-24T09:41:54Z

Do I have to add the e2e_test test case before submitting the code?

cyb70289 · 2023-04-24T09:44:49Z

Do I have to add the e2e_test test case before submitting the code?

Yes.

lijhnihaoa · 2023-04-24T09:46:59Z

Do I have to add the e2e_test test case before submitting the code?

Yes.

OK

lijhnihaoa · 2023-04-25T07:31:11Z

I have a question to ask you, after the success of the volume extension, how to verify the success of it. I want to get the persistent volume size, but I can't find an interface in the framework to get the persistent volume resources. Is there any other way?

lijhnihaoa · 2023-04-27T02:33:58Z

# git pull
Already up to date.

What should I do if the submitted code conflicts?

cyb70289 · 2023-04-27T02:38:47Z

Fix the conflict and push again?

lijhnihaoa · 2023-04-27T02:43:29Z

The pulled code is the latest. When I submitted it for the first time, I found that the changed Id was the same. I deleted it and submitted it again. Although the submission was successful, the status on the web side showed a merge conflict.

lijhnihaoa · 2023-04-27T02:50:26Z

Is it because the change of the person who committed the code before me has not yet passed？

cyb70289 · 2023-04-27T02:51:14Z

You patch is not based on latest tip (95a1911). Pull and rebase again.

lijhnihaoa · 2023-04-27T03:12:22Z

Yes, thank you, it's resolved now.

cyb70289 · 2023-05-08T07:44:36Z

@lijhnihaoa , thanks for the patch. Will you change issue title to something like "support volume expansion" to match current scope.

taoyunxing · 2023-08-07T09:09:44Z

Is the feature of volume expansion available? I need it, even though give me some suggestion are welcome.

lijhnihaoa · 2023-08-07T10:00:28Z

https://review.spdk.io/gerrit/c/spdk/spdk-csi/+/17748
You can take a look at this submitted code

xinydev · 2023-10-24T03:26:30Z

Hi,@lijhnihaoa are you still working on this?

lijhnihaoa · 2023-10-28T02:18:12Z

I don't have time recently, I have to take care of my newborn child and work. 发自我的小米在 2023年10月24日 11:26，Xin Yang ***@***.***>写道：<br type="attributi ***@***.***<https://github.com/lijhnihaoa> are you still working on this? ― Reply to this email directly, view it on GitHub<#16 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ALYZYKHH4BQL35NXQFLZC2DYA4YPFAVCNFSM6AAAAAAQXW4HICVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZWGQ2TONBSG4>. You are receiving this because you were mentioned.Message ID: ***@***.***>

lijhnihaoa closed this as completed Oct 11, 2022

lijhnihaoa reopened this Oct 13, 2022

lijhnihaoa changed the title HA support volume expansion May 14, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

support volume expansion #16

support volume expansion #16

lijhnihaoa commented Sep 28, 2022

cyb70289 commented Sep 29, 2022

lijhnihaoa commented Sep 29, 2022

lijhnihaoa commented Sep 29, 2022

cyb70289 commented Sep 29, 2022

lijhnihaoa commented Oct 11, 2022

cyb70289 commented Oct 11, 2022

lijhnihaoa commented Oct 11, 2022

lijhnihaoa commented Oct 13, 2022

cyb70289 commented Oct 13, 2022

lijhnihaoa commented Oct 13, 2022

cyb70289 commented Oct 13, 2022

lijhnihaoa commented Oct 13, 2022

lijhnihaoa commented Apr 24, 2023

lijhnihaoa commented Apr 24, 2023

cyb70289 commented Apr 24, 2023

lijhnihaoa commented Apr 24, 2023

cyb70289 commented Apr 24, 2023

lijhnihaoa commented Apr 24, 2023 •

edited

Loading

cyb70289 commented Apr 24, 2023

lijhnihaoa commented Apr 24, 2023

cyb70289 commented Apr 24, 2023

lijhnihaoa commented Apr 24, 2023

lijhnihaoa commented Apr 25, 2023

lijhnihaoa commented Apr 27, 2023

cyb70289 commented Apr 27, 2023

lijhnihaoa commented Apr 27, 2023

lijhnihaoa commented Apr 27, 2023

cyb70289 commented Apr 27, 2023

lijhnihaoa commented Apr 27, 2023

cyb70289 commented May 8, 2023

taoyunxing commented Aug 7, 2023

lijhnihaoa commented Aug 7, 2023

xinydev commented Oct 24, 2023

lijhnihaoa commented Oct 28, 2023 via email

support volume expansion #16

support volume expansion #16

Comments

lijhnihaoa commented Sep 28, 2022

cyb70289 commented Sep 29, 2022

lijhnihaoa commented Sep 29, 2022

lijhnihaoa commented Sep 29, 2022

cyb70289 commented Sep 29, 2022

lijhnihaoa commented Oct 11, 2022

cyb70289 commented Oct 11, 2022

lijhnihaoa commented Oct 11, 2022

lijhnihaoa commented Oct 13, 2022

cyb70289 commented Oct 13, 2022

lijhnihaoa commented Oct 13, 2022

cyb70289 commented Oct 13, 2022

lijhnihaoa commented Oct 13, 2022

lijhnihaoa commented Apr 24, 2023

lijhnihaoa commented Apr 24, 2023

cyb70289 commented Apr 24, 2023

lijhnihaoa commented Apr 24, 2023

cyb70289 commented Apr 24, 2023

lijhnihaoa commented Apr 24, 2023 • edited Loading

cyb70289 commented Apr 24, 2023

lijhnihaoa commented Apr 24, 2023

cyb70289 commented Apr 24, 2023

lijhnihaoa commented Apr 24, 2023

lijhnihaoa commented Apr 25, 2023

lijhnihaoa commented Apr 27, 2023

cyb70289 commented Apr 27, 2023

lijhnihaoa commented Apr 27, 2023

lijhnihaoa commented Apr 27, 2023

cyb70289 commented Apr 27, 2023

lijhnihaoa commented Apr 27, 2023

cyb70289 commented May 8, 2023

taoyunxing commented Aug 7, 2023

lijhnihaoa commented Aug 7, 2023

xinydev commented Oct 24, 2023

lijhnihaoa commented Oct 28, 2023 via email

lijhnihaoa commented Apr 24, 2023 •

edited

Loading