Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move slf4j implementation to test scope #188

Merged

Conversation

Gr33ndev
Copy link
Contributor

@Gr33ndev Gr33ndev commented Jul 10, 2023

sorry, I saw this too late: the library should not force ANY implementation
it's up to the library user to choose what logging implementation he uses:

  • Maven uses something
  • someone else in another runtime context will choose another implementation

in the context of the library, perhaps setting an implementation with a test scope can make sense

After this discussion in my last PR #185 here is the requested change.

@Gr33ndev Gr33ndev changed the title move slf5j implementation to test scope move slf4j implementation to test scope Jul 10, 2023
Signed-off-by: Gilian Rehm <g_rehm@ich-habe-fertig.com>
@Gr33ndev Gr33ndev force-pushed the move-slf4j-implementation-to-test-scope branch from 745f549 to dddc42b Compare July 10, 2023 21:17
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Gr33ndev

@goneall goneall merged commit 4666b45 into spdx:master Jul 10, 2023
@Gr33ndev Gr33ndev deleted the move-slf4j-implementation-to-test-scope branch July 10, 2023 23:05
@Gr33ndev
Copy link
Contributor Author

You‘re welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants