Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-238: Return null if ID does not exist #239

Merged
merged 1 commit into from
May 16, 2024
Merged

Conversation

dwalluck
Copy link
Contributor

ListedLicenses::getListedLicenseById and ListedLicenses::getListedExceptionById should return null if ID does not exist.

Resolves GH-238

`ListedLicenses::getListedLicenseById` and `ListedLicenses::getListedExceptionById` should return `null` if ID does not exist.

Resolves spdxGH-238

Signed-off-by: David Walluck <dwalluck@redhat.com>
Copy link
Collaborator

@pmonks pmonks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me @goneall!

Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @dwalluck

@goneall goneall merged commit 6388208 into spdx:master May 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Method LicenseInfoFactory::getListedLicenseById never returns null
3 participants