Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python-2.0 license should not include all the history of Python licensing #919

Closed
pombredanne opened this issue Aug 27, 2019 · 14 comments · Fixed by #952
Closed

Python-2.0 license should not include all the history of Python licensing #919

pombredanne opened this issue Aug 27, 2019 · 14 comments · Fixed by #952
Assignees
Labels
XML markup change potential change or addition to XML markup in license
Milestone

Comments

@pombredanne
Copy link
Member

The Python-2.0 license is used in Python proper and in other projects. Yet the Python-2.0 text @ SPDX is really the whole Python.org license notice and history, making this is license text useless outside of the Python.org licensing.

@swinslow
Copy link
Member

swinslow commented Sep 5, 2019

@pombredanne I'm in favor of this. Looking at https://github.com/spdx/license-list-XML/blob/master/src/Python-2.0.xml, is your suggestion that Python-2.0 should be just lines 14-65? With the remainder punted out into separate license entries (possibly Python-1.X, Python-1.Y variants)?

I do note that CNRI-Python already exists for one part of the older version "history" chunks. I haven't run a redline against the center part of what's currently in Python-2.0, but flipping between tabs it sure does look the same...

@swinslow
Copy link
Member

swinslow commented Sep 5, 2019

That being said, a couple of downsides to making this change --

  • the OSI definition of Python-2.0 includes the full "history" text -- see https://opensource.org/licenses/Python-2.0. (Perhaps, if we change, it should only be concurrent with OSI making a change so that they stay in sync?)

  • For Python itself (the language implementation), is it under just the Python-2.0 portion of this? Or does the standard Python distribution contain code that is still under the earlier licenses? If we were to break them out into separate entries, it would be a shame if that meant that the license for Python became something like Python-2.0 AND Python-1.6b1 AND Python-1.2 AND...

@pombredanne
Copy link
Member Author

@swinslow You are right: changing the current Python-2.0 text is likely a bad idea. Yet we need a way to handle projects that use strictly the text from

<p>PYTHON SOFTWARE FOUNDATION LICENSE VERSION 2</p>
to and are not Python (and therefore do not need to cargo the history of Python licensing)

One possibility, we could have new id --e.g. PSF-2.0-- that contains only this text and leave the Python one as is. As you pointed out it is not the first time that there is an id text contained in another text. This would offer the maximum flexibility with the minimum changes

@jlovejoy
Copy link
Member

jlovejoy commented Sep 5, 2019

@pombredanne - are you suggesting that we have a new entry that is only the part lines 10-65? What is the justification of this - that is, are you finding this alone in the wild and if so, can you point to an example?
thanks!

@jlovejoy
Copy link
Member

@pombredanne - can you clarify the resulting idea here?

btw, I should have mentioned that in long ago, ancient history SPDX license list, one of our early contributors did a TON of research on the Python license "stack", as we referred to it, in terms of trying to understand what was used for which version of Python. There was a chart I believe, which was somewhat dizzying. If I can find that, it might be a good thing to store on the wiki for posterity.

@jlovejoy jlovejoy added this to the 3.8 release milestone Oct 19, 2019
@rohieb
Copy link
Contributor

rohieb commented Nov 13, 2019

@pombredanne - are you suggesting that we have a new entry that is only the part lines 10-65? What is the justification of this - that is, are you finding this alone in the wild and if so, can you point to an example?

I'm finding this part of the Python-2.0 license text alone in the wild, e.g. in scipy-sphinx-theme, so I would welcome this part as a single license.

@pombredanne
Copy link
Member Author

@rohieb Thanks
@jlovejoy sorry for the late reply: the point is that non-PSF code that is under the Python license will not have the historical baggage that the PSF Python license has because these other historical licenses just do not apply.

@rohieb
Copy link
Contributor

rohieb commented Dec 4, 2019

@jlovejoy wrote:

btw, I should have mentioned that in long ago, ancient history SPDX license list, one of our early contributors did a TON of research on the Python license "stack", as we referred to it, in terms of trying to understand what was used for which version of Python. There was a chart I believe, which was somewhat dizzying. If I can find that, it might be a good thing to store on the wiki for posterity.

The chart is even part of Python's LICENSE file :-) https://github.com/python/cpython/blob/master/LICENSE#L27

rohieb added a commit to rohieb/license-list-XML that referenced this issue Dec 4, 2019
@rohieb
Copy link
Contributor

rohieb commented Dec 4, 2019

@pombredanne wrote:

Yet we need a way to handle projects that use strictly the text from

<p>PYTHON SOFTWARE FOUNDATION LICENSE VERSION 2</p>

to


and are not Python (and therefore do not need to cargo the history of Python licensing)

One possibility, we could have new id --e.g. PSF-2.0-- that contains only this text and leave the Python one as is.

I've done exactly that in PR #952 now, would be great if you could have a look whether that's what you want.

@swinslow swinslow added the XML markup change potential change or addition to XML markup in license label Dec 31, 2019
@swinslow
Copy link
Member

I'm in favor of the approach @rohieb implemented in #952, by adding a new "PSF-2.0" entry that contains just the specific license text without the historical text. (I'll have a couple of minor comments on #952 itself)

@pombredanne @jlovejoy, does that work for you also? Any concerns or are you good with the proposal in #952?

@bradleeedmondson
Copy link
Contributor

The approach in #952 makes sense to me.

@rohieb
Copy link
Contributor

rohieb commented Jan 20, 2020

@swinslow:

(I'll have a couple of minor comments on #952 itself)

Do you still have? I don't see them on #952

@swinslow
Copy link
Member

Discussed on 2020-01-30 legal team call, OK to merge #952, will want to add listVersionAdded tag but can do that post-merge.

@rohieb
Copy link
Contributor

rohieb commented Jan 30, 2020

@swinslow thanks for the cleanup! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
XML markup change potential change or addition to XML markup in license
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants