Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zlib: add copyrightText as often seen in wild, including crossrefs #482

Merged
merged 1 commit into from
Dec 19, 2017
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/Zlib.xml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@
<titleText>
<p>zlib License</p>
</titleText>

<copyrightText>
<p>Copyright (c) &lt;year&gt; &lt;copyright holders&gt;</p>
Copy link
Contributor

@wking wking Nov 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This occurs in the upstream text and in the OSI page [edit: which I now realize is what you were saying with “including crossrefs” :p], so I think this is something we certainly want. The “as often seen in the wild” caveat seems like it's closer to “as seen everywhere outside of SPDX, until it was fixed by this commit” ;).

</copyrightText>
<p>This software is provided 'as-is', without any express or implied warranty. In no event will the authors
be held liable for any damages arising from the use of this software.</p>
<p>Permission is granted to anyone to use this software for any purpose, including commercial applications,
Expand All @@ -30,6 +32,6 @@
This notice may not be removed or altered from any source distribution.
</item>
</list>

</license>
</SPDXLicenseCollection>
</SPDXLicenseCollection>