-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Software/contentType (duplicative) #789
Conversation
- Update the `Core/Properties/contentType.md` with wording from `Software/Properties/contentType.md`, adjusted to accommodate both Element and Property - Update `Core/Datatypes/MediaType.md` to accommodate both Element and Property, also add string examples - Remove `Software/Properties/contentType.md` file - Update `Software/Classes/File.md` to refer to `/Core/contentType` instead of `contentType` - Update examples: `file1.json` and `spdx_document2.json` Co-Authored-By: Alexios Zavras (zvr) <136705+zvr@users.noreply.github.com> Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Add info on the removal of `Software/contentType` Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks @bact
@JPEWdev - This would be a breaking change for existing 3.0.0 users. We're thinking of merging this into 3.0.1 - would this be a problem for your Yocto work? |
Update examples to cover media type that: - contains `+` suffix and `;` parameter - is from `vnd.` vendor tree Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
No, we aren't using that field. Is it possible to "hide" it in the spec, but leave it in the RDF so it's backward compatible maybe? |
@JPEWdev - good to know. For the RDF, we could keep the My opinion is if we get this changed quickly and release 3.0.1 with the changes, it won't impact many folks since we're in the early phases of 3.0 adoption. I'm going to go ahead and merge this change. @zvr if you have time - feel free to update the spec parser. |
Core/Properties/contentType.md
with wording fromSoftware/Properties/contentType.md
, adjusted to accommodate both Element and PropertyCore/Datatypes/MediaType.md
to accommodate both Element and Property, also add string examplesSoftware/Properties/contentType.md
fileSoftware/Classes/File.md
to refer to/Core/contentType
instead ofcontentType
file1.json
andspdx_document2.json
This should resolve #781